Feature/tests add fields #177
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey Pat! I just left a comment on another PR explaining the delay here: TL;DR we hadn't thought through schema migrations for new fields and are grappling with that now! Stay tuned! |
|
Thanks for the info -- no rush on my end! |
|
Hey @patkearns10 I just merged 188 which unblocks this. My recommendation might actually be closing this PR and reopening a fresh one rather than trying to rebase since so much code changed in that PR. Up to you of course! |
|
Hey @patkearns10, let us know if we can help out at all with getting this ready for merge. They’re really great additions! |
|
Closing this in favor of #213 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a few Test dimensions that could make analysis a bit easier.
short_name= shorter version of the test name, example. 'unique', instead of long nameunique_my_first_model_coltest_type= 'singular' or 'generic'test_severity_config= 'ERROR' or 'WARN'model_refs= short name of model dependenciessource_refs= short name of src dependencies